Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(callback): RFC 6749 Section 4.1.2.1 #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SmartArray
Copy link

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

This PR prevents the server from timing out when the user is redirected to the /callback uri with an error code instead of a code.

References

The implementation follows RFC 6749 Section 4.1.2.1 (responds with all information whenever query string error is set).

Testing

  • Use an openId server that requires PKCE or so

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@SmartArray
Copy link
Author

Just found that there is an issue tracker too:

#16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant