Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak sshjail: Add changes for ansible 2.12 #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

grembo
Copy link
Contributor

@grembo grembo commented Feb 12, 2022

Fixes this error:

ansible.errors.AnsibleError: Requested entry (plugin_type: connection plugin: sshjail setting: pkcs11_provider ) was not defined in configuration.

@wombelix
Copy link

Looks like a duplicate? Isn't that already covered by PR #38 ?

@grembo
Copy link
Contributor Author

grembo commented Mar 26, 2022

Looks like a duplicate? Isn't that already covered by PR #38 ?

There's overlap:

  1. Both address the error I mention above
  2. Unbreak sshjail: Add changes for ansible 2.12 #39 also incorporates the missing ssh_transfer_method from https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/connection/ssh.py#L296-L297
  3. Unbreak sshjail: Add changes for ansible 2.12 #39 adds pkcs11_provider 1:1 from current https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/connection/ssh.py#L347-L357 - these are just cosmetic differences, but having it identical makes sense for future diffs/development
  4. fix: ansible 2.12 and + compat + become fix #38 adds an important fix to _copy_file, which is not addressed by Unbreak sshjail: Add changes for ansible 2.12 #39 (it's a different issue)

So ideally, they are combined, e.g., by updating #38 with the points 2. and 3. mentioned above and then closing this one as a duplicate.

@wombelix
Copy link

Thank you very much @grembo for the explanation and pointing out the differences of both pull requests.

wombelix added a commit to wombelix/fork_austinhyde_ansible-sshjail that referenced this pull request Mar 26, 2022
wombelix added a commit to wombelix/fork_austinhyde_ansible-sshjail that referenced this pull request Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants