Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change my-app to just app and some QOL webpack stuff #67

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

brandonseydel
Copy link
Member

No description provided.

@3cp
Copy link
Member

3cp commented Oct 16, 2021

There is a reason for the verbose <my-app> tag name.
<app> does not work in ShadomDom, ShadowDom requires a dash in custom element tag name like <my-app>.

@3cp
Copy link
Member

3cp commented Oct 16, 2021

For reference, we have a warning for user on such ShadowDom requirement (It's from ShadowDom spec, not Aurelia):
https://github.com/aurelia/aurelia/blob/b5356ce80cee2022186950ee3d023f5d063ff05a/packages-cjs/plugin-conventions/src/preprocess-html-template.ts#L43

@zewa666
Copy link
Member

zewa666 commented Oct 16, 2021

perhaps scaffold the name like <projectname>-app?

@brandonseydel
Copy link
Member Author

perhaps scaffold the name like <projectname>-app?

Yea that was the eventual goal. As far as shadow dom. Do not hurt the 99% for the 1% is my motto. Shadow DOM people rename it.

@brandonseydel
Copy link
Member Author

app-root would be something of better taste as well perhaps

@3cp
Copy link
Member

3cp commented Oct 22, 2021

Yes, app-root sounds better than my-app.

BTW, I don't think "makes"' default project name "my-app" matters. People will change it anyway when creating real project. We can even set default project name to "" to force user to type.

@brandonseydel
Copy link
Member Author

@3cp - You give way too much credit. Developers are not like they used to be. They leave it out of the box and tack on. Just like CRA (they don't touch shit)

@3cp
Copy link
Member

3cp commented Oct 22, 2021

Might be true. But you should not say that in public :D
In that case, how ~/my-app/ is worse than ~/app/? :-)

@brandonseydel
Copy link
Member Author

Its just not professional enough to release into the wild is all.

@3cp
Copy link
Member

3cp commented Oct 23, 2021

I don't mind the project name change much. (au2-app might be a good candidate too)
For the root component name, let's do <app-root>, it's very clear. The ${projectname}-app is not bad, but it requires more coding without justified benefit. I like the simpler <app-root>.
If you update the branch, we can merge them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants