Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(create-aurelia): holder for create-aurelia #1636

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

brandonseydel
Copy link
Member

Pull Request

πŸ“– Description

🎫 Issues

πŸ‘©β€πŸ’» Reviewer Notes

πŸ“‘ Test Plan

⏭ Next Steps

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #1636 (5118a5e) into master (bcf8afd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1636   +/-   ##
=======================================
  Coverage   87.73%   87.73%           
=======================================
  Files         240      240           
  Lines       22167    22167           
  Branches     5005     5005           
=======================================
  Hits        19448    19448           
  Misses       2719     2719           

πŸ“£ We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Sayan751 Sayan751 requested a review from 3cp January 10, 2023 17:28
@3cp
Copy link
Member

3cp commented Jan 10, 2023

I think the trend is to use name "create-aurelia-app"? (Following create-react-app and create-vue-app).

It will be used as "npm create aurelia-app", instead of "npm create aurelia" in this PR.

@brandonseydel
Copy link
Member Author

brandonseydel commented Jan 13, 2023

It's the name on npm which does not have app in it.

npm create vue|svelte|solid etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants