New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added KindsOf method to Value type #37

Open

afinch7 wants to merge 2 commits into augustoroman:master from afinch7:master

afinch7 commented Nov 30, 2018

Pretty simple stuff just added a KindsOf method for the Value type, and a KindList type with a method String.

Should allow for a little better error reporting from bound functions.

I.E.

func someBoundMethod(in v8.CallbackArgs) (*v8.Value, error) {
    if !in.Arg(0).IsKind(v8.KindString) {
	return nil, errors.New("Expected String type for arg 0 but got: " + in.Arg(0).KindsOf().String() + ".")
    }
}

I would imagine there are other uses this is just the one that motivated me to make this pr.

afinch7 added 2 commits

November 30, 2018 14:30


          Added Kinds method to kindMask and KindList method with String method.

75bc297


          Added KindsOf method to Value.

32eea15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment