Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous improvements #2

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Miscellaneous improvements #2

wants to merge 11 commits into from

Conversation

paulrw
Copy link
Contributor

@paulrw paulrw commented Jan 31, 2014

Improvements:

  • Enabled support for using custom session controllers
  • Fixed bug in test environment authentication
  • Added realm to username when authenticating so users can just give their username
  • Stopped trying to set password when creating user
  • Updated readme

These changes will probably break existing apps that use this gem due to the change from authenticating by username and realm to just username. You may not want to pull these changes in, or if you do you might want to bump the version number. We found these changes were helpful for our use of this gem, maybe they won't be helpful for yours.

@atomaka
Copy link
Owner

atomaka commented Feb 4, 2014

Thanks for the PR, @paulrw. I plan on checking these changes out over the weekend. Sorry for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants