Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protected (some) complex variants from left-trimming in normalize #75

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

selkovjr
Copy link

This patch prevents the trimming of complex variants that are already normalized.

Example: trimming CAT -> CG changes it to a form that is hard to analyze: AT -> G. Indeed, some tools, such as freebayes, interpret it incorrectly, while the original combination of a deletion and a SNP presents no problems.

I do not know whether the solution I present here is complete (I suspect not), but it fixes all instances of this type of error I was able to find in my data.

@atks
Copy link
Owner

atks commented Aug 17, 2017

@selkovjr - I cannot accept this PR because:

  1. it would contradict the definition of normalization
  2. it is not practical to make exceptions so that a downstream tool will work
  3. It is probably a better idea for you to add an intermediate step between vt normalize and freebayes to manipulate the variants

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants