Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operations): Implements Serializer and Deserializer interface #17

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

Satyam6623165
Copy link
Member

Features:

  • Resolves deserialisation issues with previously implemented interface
  • Implements serialize and deserialize methods for all node types
  • Unit tests for the serialization and deserialization interface

close #12

@Satyam6623165 Satyam6623165 added the enhancement New feature or request label Nov 17, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #17 (8f22c3f) into main (b6e1e37) will increase coverage by 6.55%.
The diff coverage is 90.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   77.56%   84.11%   +6.55%     
==========================================
  Files           7        7              
  Lines         205      214       +9     
==========================================
+ Hits          159      180      +21     
+ Misses         39       27      -12     
  Partials        7        7              
Impacted Files Coverage Δ
operations/defs/list_node.go 75.47% <83.87%> (+9.47%) ⬆️
operations/defs/deepcopy_util.go 69.56% <85.71%> (ø)
operations/defs/json_node.go 93.10% <91.42%> (ø)
operations/defs/register_node.go 80.00% <93.75%> (+17.03%) ⬆️
operations/defs/map_node.go 78.94% <100.00%> (+28.94%) ⬆️
operations/serializer/serializer.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6e1e37...8f22c3f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Serialize and Deserialize Interface
2 participants