Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Serialize and Deserialize Interface #12

Open
bisakhmondal opened this issue Oct 27, 2021 · 3 comments · Fixed by #14 · May be fixed by #17
Open

Implement Serialize and Deserialize Interface #12

bisakhmondal opened this issue Oct 27, 2021 · 3 comments · Fixed by #14 · May be fixed by #17
Assignees
@Satyam6623165
Labels
enhancement New feature or request
Projects
TaskLists

Comments

@bisakhmondal
Copy link
Member

bisakhmondal commented Oct 27, 2021 •
edited

Feature Request

Summary

Implement Serializer Interface with Serialize & Deserialize methods.

pkg location operations/serializer/serializer.go

Solution

Two Struct implements Serializer interface

  • JsonSerializer (Make Sense as we are dealing with JSON tree)
  • GOBSerialize (binary)
  • Link it to Json TreeTypes
  • Provide flexibility to switch serializer and a default serializer
@bisakhmondal bisakhmondal added the enhancement New feature or request label Oct 27, 2021
@bisakhmondal bisakhmondal added this to To do in TaskLists via automation Oct 27, 2021
@bisakhmondal bisakhmondal moved this from To do to In progress in TaskLists Oct 27, 2021
@bisakhmondal
Copy link
Member Author

@Satyam6623165 Would you like to pick it up?

@Satyam6623165
Copy link
Member

Sure . Will work on it today itself . Can you explain the last point a bit ?

@Satyam6623165 Satyam6623165 mentioned this issue Oct 27, 2021
Merged
@bisakhmondal bisakhmondal moved this from In progress to Review in progress in TaskLists Oct 29, 2021
@bisakhmondal
Copy link
Member Author

Refactor

Update the Private variable of baseNode, RegisterNode to public variables.
Else serialization won't work : ) [GOB can't serialize variables which it can't see itself]

PS. Handle it on a separate PR😉😇

TaskLists automation moved this from Review in progress to Done Oct 30, 2021
@bisakhmondal bisakhmondal reopened this Oct 30, 2021
TaskLists automation moved this from Done to In progress Oct 30, 2021
@Satyam6623165 Satyam6623165 linked a pull request Nov 17, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Satyam6623165 Satyam6623165

Labels
enhancement New feature or request
Projects
TaskLists
In progress
Milestone
No milestone
2 participants
@Satyam6623165 @bisakhmondal