make vhost "looks like a CIDR" check more precise #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesopo
force-pushed
the
jess/less-bad-cidr-check
branch
3 times, most recently
from
61333cd
to
955cbd8
Compare
jesopo
force-pushed
the
jess/less-bad-cidr-check
branch
from
955cbd8
to
bd119ca
Compare
dwfreed
suggested changes
Feb 23, 2024
| p++; | ||
| // if we found a /, and are now at the end of the vhost, that | ||
| // means we found no non-digits, so it looks too much like a CIDR | ||
| if (p2 != NULL && p[1] == '\0') |
There was a problem hiding this comment.
This doesn't need storing a second copy of the strrchr return value. If the return value was NULL then p will still be NULL here; if the return value was not NULL then p will never be NULL either.
|
this PR may be a no-go anyway as it'd apparently require us to audit all the IRCds atheme can link with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i don't know if this code was intentionally very imprecise but it's blocking a cloak we'd like to use that is quite obviously fine