Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/protocol/unreal4: Adjust default usermodes for service bots to include TLS-only & hide ircop usermodes #918

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

alicetries
Copy link
Contributor

@alicetries alicetries commented Feb 3, 2024

This adjusts atheme's services bots to include +z and +H as part of their introduced usermodes.

When +z (connected securely) isn't set on the service bot, and a services bot joins a +z (only secure clients can join) channel which only contains secure clients, then Unreal will send a NOTICE to the channel indicating the channel is no longer "secure" and unset +Z (which indicates that only secure clients are in the channel)

When +H (oper status hidden in /who, /whois & /lusers) isn't set on the service bot, the number of operators in /lusers appears higher than the number of "real" operators, as unreal doesn't exclude +S (services user) users from the list of operators.

@jesopo
Copy link
Member

jesopo commented Feb 3, 2024

what does +H mean? what does the mode signify?

@alicetries
Copy link
Contributor Author

Ah, that'll teach me to not proof-read my comment.

+H causes the services bots to not be counted as 'operators' for the purposes of /who, /whois, /lusers and similar.
Unreal (unlike charybdis/solanum) doesn't exempt services users from those commands, which can cause some confusion with people wondering why their network has 16 operators on it (according to /lusers), where they only actually have a few real human operators & would prefer it to only show the "real" operators.

I appreciate it's more of an aesthetic issue, but there's been a few people mention this in #unreal-support over the past few months and finding it somewhat confusing.

@jesopo
Copy link
Member

jesopo commented Feb 4, 2024

oh no im happy with this pr even for just aesthetics. just wondered if H had another meaning than just "hide from oper counts" to know if we'd be opting ourselves into other things by doing it. if not then :shipit:

@alicetries
Copy link
Contributor Author

Hmm. Unreal's source & wiki suggest "HideOper" / "Hide IRCop", and appears to just deal with the visibility of oper status in /who and such & maintaining the oper count for /lusers within source.

Think the closest equivalent is oper:hidden in charybdis/solanum, if that helps.

@aaronmdjones aaronmdjones merged commit 4e3dfaa into atheme:master Feb 4, 2024
2 checks passed
@alicetries alicetries deleted the alicetries-patch-unreal4-1 branch February 4, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants