Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include FNC_REGAIN/FNC_FORCE in ts6-generic's RSFNC #899

Merged
merged 1 commit into from
Jun 3, 2023
Merged

include FNC_REGAIN/FNC_FORCE in ts6-generic's RSFNC #899

merged 1 commit into from
Jun 3, 2023

Conversation

jesopo
Copy link
Member

@jesopo jesopo commented Apr 6, 2023

it may be better to only send this extra parameter to servers whose CAPAB/GCAP have indicated they support it. thoughts?

@jesopo jesopo mentioned this pull request Apr 6, 2023
Merged
@jesopo
Copy link
Member Author

jesopo commented Apr 6, 2023

c.f. solanum-ircd/solanum#406

@jesopo
Copy link
Member Author

jesopo commented Apr 6, 2023 •
edited

it may be better to only send this extra parameter to servers whose CAPAB/GCAP have indicated they support it. thoughts?

annoyingly, it doesn't look like we record GCAP so we can't (currently) check what capabs the target server has, given RSFNC travels through uplink unmodified to the target server

@aaronmdjones aaronmdjones merged commit 22bba9a into master Jun 3, 2023
2 checks passed
@aaronmdjones aaronmdjones deleted the jess/rsfnc-type branch June 3, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jesopo @aaronmdjones