modules/operserv/: add a channel join rate monitoring module #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jillest
reviewed
Apr 5, 2023
jesopo
reviewed
Jun 3, 2023
I thought this was better as a first-party module than to put it in contrib. I have reworked it to adhere to the 7.3 type system and conventions, and add module reload support such that no data loss will occur. Closes atheme/atheme-contrib-modules#49 Closes atheme/atheme-contrib-modules#50 Co-authored-by: Jess <github@lolnerd.net>
aaronmdjones
force-pushed
the
jesopo/os-joinrate
branch
from
71a0e3e
to
ac11e7c
Compare
jesopo
approved these changes
Jun 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought this was better as a first-party module than to put it in contrib. I have reworked it to adhere to the 7.3 type system and conventions, and add module reload support such that no data loss will occur.
This still needs to be thoroughly tested.