refactor out hostmask formatting #880
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilbelkyr
requested changes
Oct 29, 2022
| @@ -21,6 +21,8 @@ static mowgli_heap_t *user_heap = NULL; | |||
| mowgli_patricia_t *userlist; | |||
| mowgli_patricia_t *uidlist; | |||
|
|
|||
| char hostmaskbuf[NICKLEN + USERLEN + HOSTLEN + 2]; | |||
There was a problem hiding this comment.
this needs an extra byte for the string terminator; i'd also add a comment explaining where the number comes from to avoid people making mistakes in the future
you could also put this as static inside the format_hostmask function i think; might be a bit cleaner?
| const char * | ||
| format_hostmask(const struct user *user, const enum host_type type) | ||
| { | ||
| sprintf(hostmaskbuf, "%s!%s!%s", user->nick, user->user, user->vhost); |
There was a problem hiding this comment.
this currently just does user->vhost without checking the requested host type
i'd probably use snprintf with sizeof hostmaskbuf here for safety
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i plan to use this function in more places that already format hostmasks, but i wanted to open this PR early to see if this is the right way of going about this. returning a pointer means (i believe) that you can't call this and store its results consecutively, but i think that might be an ok cost for not having to free things