add a hook to allow modules to handle sending emails #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glguy
reviewed
Sep 18, 2021
jillest
reviewed
Sep 18, 2021
| }; | ||
| hook_call_sendemail(&hdata); | ||
| if (hdata.handled) | ||
| return -1; |
There was a problem hiding this comment.
maybe this hook call should be before validating the email type so the email handling hook can decide if it's valid or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
placement of the hook call may be controversial, returning
-1to avoid falsiness but not get in the way of exit codes may also be controversial