check user_can_login *before* checking certfp #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilbelkyr
requested changes
Sep 28, 2021
|
if this solution is acceptable, merge atheme/atheme-contrib-modules#53 first (and get e.g. libera.chat to deploy these at the same time) |
aaronmdjones
requested changes
Sep 29, 2022
jesopo
force-pushed
the
certfp-can-login-before
branch
from
aa4621d
to
e3703b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this isn't important, but you can actually expose that your current certfp matches an account without being able to log in to it if the target account already has max logins