Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libathemecore/ptasks: handle status-prefixed channel messages #823

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Aug 31, 2021

  1. libathemecore/ptasks: handle status-prefixed channel messages

    If a channel message comes in with a status prefix, we should still
    treat it as a channel message.
    
    This does not raise concerns about chanops hiding the usage of fantasy
    commands because they can always private message services directly and
    the output of potentially-abusive commands (for example, kick) is
    signed off with their account name anyway (which will not change).
    
    Under the solanum family of IRCds, there exists a channel mode +z,
    which will transform messages to #channel into messages to @#channel
    if the message would have been blocked by +m/+b/+q. This is to clearly
    distinguish to channel operators that the only reason they are seeing
    the message is that they are operators, and that other channel users
    will not have seen it.
    
    ChanServ is also a channel operator, but it would not have received
    the message, because services ignored status-prefixed channel messages.
    This prevented users using fantasy commands if they are affected by +z;
    for example, by the channel being +m. Confusingly, this would have
    allowed "!deop" to work, but not "!op".
    
    Reported by juggs on IRC, who did not respond to a request for the
    proper attribution in Reported-by.
    aaronmdjones committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    da21782 View commit details
    Browse the repository at this point in the history