Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only call ircd_on_logout when the ircd knows a user is logged in #818

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

only call ircd_on_logout when the ircd knows a user is logged in #818

wants to merge 4 commits into from

Conversation

jesopo
Copy link
Member

@jesopo jesopo commented Aug 16, 2021

closes #708. annoying that I had to do it in so many places but I didn't see another option

ilbelkyr
ilbelkyr reviewed Sep 29, 2021
View reviewed changes
Copy link
Member

@ilbelkyr ilbelkyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so far this looks good. there's also another ircd_on_logout call in myuser_rename; that should probably be gated behind the same check (mirroring #830)?

libathemecore/services.c Show resolved Hide resolved
@jesopo jesopo requested a review from ilbelkyr October 15, 2021 13:44
@jesopo jesopo requested review from ilbelkyr and removed request for ilbelkyr December 30, 2021 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilbelkyr ilbelkyr Awaiting requested review from ilbelkyr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

freenode user generated :nick ACCOUNT * from dropping an unverified account
2 participants
@jesopo @ilbelkyr