Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canonicalise emails before checking them against BADMAIL #817

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jesopo
Copy link
Member

@jesopo jesopo commented Aug 16, 2021

closes #773

@jesopo
Copy link
Member Author

jesopo commented Aug 16, 2021

maybe worth checking both noncanonicalised and canonicalised?

@jesopo
Copy link
Member Author

jesopo commented Aug 16, 2021

<@amdj> jess: #817 leaks memory; you need to strshare_unref() the result before returning.

@spb
Copy link
Contributor

spb commented Sep 17, 2021

maybe worth checking both noncanonicalised and canonicalised?

Better to canonicalise the badmail entries, IMO.

@jesopo
Copy link
Member Author

jesopo commented Sep 17, 2021

no, we get temporary mail providers that use dots in gmail addreses to differentiate addresses and I'd like to badmail *.*.*.*.*@gmail.com but we canonicalise dots out of gmail addresses

@spb
Copy link
Contributor

spb commented Sep 17, 2021

OK, fair point. In that case you'll have to test both versions.

@jesopo jesopo marked this pull request as draft September 17, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

canonicalise badmail
2 participants