This repository has been archived by the owner on Nov 13, 2022. It is now read-only.
Simple coworkers view #40
Open
MartinDelille
wants to merge
11
commits into
master
Choose a base branch
from
all-coworkers-listing
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinDelille
force-pushed
the
all-coworkers-listing
branch
from
October 8, 2020 15:04
afd5f57
to
034b9f5
Compare
|
||
{% for p in page.collection %} | ||
<h2>{{ p.header.custom.first_name}} {{p.header.custom.last_name }}</h2> | ||
<img src="coworkers/{{ p.title | lower }}/{{ p.header.custom.profile_picture }}" alt="{{p.header.custom.first_name}} {{p.header.custom.last_name}}"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MartinDelille Ici c'est risqué de prendre p.title
car il pourrait y avoir une différence entre le nom de la page et le slug url dont on a besoin ici qui est le nom du dossier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est réglé!
MartinDelille
force-pushed
the
all-coworkers-listing
branch
from
February 21, 2021 12:14
fc5abf0
to
37ed4a9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@willybrauner Voici une implementation basique d'une page affichant tous les coworkers.