Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation warning in node-sass 4.0 #245

Open
wants to merge 3 commits into
base: 1.x.x
Choose a base branch
from

Conversation

ApacheEx
Copy link

There are a lot of such warnings:

DEPRECATION WARNING: Passing a string to call() is deprecated and will be illegal
in Sass 4.0. Use call(get-function("output-float")) instead.

This PR is going to fix them 馃挴

@ApacheEx
Copy link
Author

ApacheEx commented Apr 16, 2018

To use just a get-function we need to have at least sass 3.5.0. So I've added backward capability which support sass 3.3.x and up.

Or on another side we can upgrade sass deps to 3.5.0+ and remove this legacy support.

@ApacheEx ApacheEx changed the title Remove deprecation warning in sass 4.0 Remove deprecation warning in node-sass 4.0 Apr 16, 2018
@joaogarin
Copy link

Currently facing the same issue, would be great to get a fix on it ;)

@walterjenner
Copy link

We are experiences the same problem in our project. Is there any change to get the fix in soon?

@ApacheEx
Copy link
Author

ApacheEx commented Jun 18, 2018

It seems project is not maintained.

What I do:

  1. install patch-package: npm i patch-package
  2. add to your package.json:
"scripts": {
  "prepare": "patch-package"
}
  1. create a folder patches in root of your project and put https://gist.github.com/ApacheEx/3a0296391c14b5103e3bad461e55b316 as patches/singularitygs+1.8.0.patch.
  2. run npm i

or just create a fork and apply this patch/PR.

@hjblokland
Copy link

Thnx @ApacheEx works like a charm!

joaogarin added a commit to jobiqo/recruiter_epiq_deps that referenced this pull request Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants