New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement "Unset Headers" keyword #134
base: master
Are you sure you want to change the base?
Conversation
Thanks for the PR @mrehanabbasi ! Could you please open this PR to the Eficode fork of this repo? We'll collect a release there and then make a release PR here. It might be only me, but I think Also, it's unclear from the keyword documentation whether something like For debugging purposes, it could be also useful if the keyword (optionally) logged headers that were not deleted or even throws an error depending on the use case, e.g
|
Hey @asimell.
It is okay either way for me. I can make the changes if you want.
It won't work with the existing code. I do plan on updating it soon as it is more developer-friendly.
That is a nice suggestion. I'll add this as well.
I will do that after making the necessary changes suggested above. |
Could you elaborate on this a bit? What do you mean by "more developer-friendly"? Could you also add acceptance tests for this new keyword ( |
I meant that adding only header names instead of the whole values will be more "developer-friendly".
Will try. |
Ah, sorry, I misread your initial comment. I read it as "the current code is not developer-friendly, so I will not do it". 😅 Please, carry on. |
Add the keyword "Unset Headers" to unset existing headers.