New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve spectra arithmetic #998
base: main
Are you sure you want to change the base?
Conversation
TST: Add a test case that fails currently but should pass when code is implemented. Also refactored some tests for arithmetic.
incompatible unit
I don't think the remote data failure is related. It has something to do with this file that I didn't touch. https://data.sdss.org/sas/dr8/sdss/spectro/redux/26/0273/spPlate-0273-51957.fits |
If we ever come back to this, need to also consider the implication of astropy/astropy#13977 |
Is there still interest to pursue this or should I just close it without merge? |
Yes, there's still interest, but I milestoned it to 2.0 so I haven't been in a rush to get it in. |
Fix #989 and more.
馃惐
TODO
astropy.units.Quantity.__array_ufunc__()
to returnNotImplemented
if the inputs are incompatible聽astropy#13977