Re-do of plot_quick #1106
Open
Re-do of plot_quick #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1106 +/- ##
==========================================
+ Coverage 70.74% 70.81% +0.07%
==========================================
Files 64 64
Lines 4484 4509 +25
==========================================
+ Hits 3172 3193 +21
- Misses 1312 1316 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a re-do of #650 for the current state of affairs where
ndcube's plot() method exists onSpectrum1D. After some testing, a group of us realized thendcubeplot doesn't really represent well what plotting should be doing for a Spectrum1D. So this PR movesplot_quickto override the.plot()of ndcube. A few others at the workshop will fill in a follow-on comment later with the experimentation that demonstrated to this group why this is a good idea.