added filter_non_finite flag to fit_lines #1078
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshanahan1
requested review from
eteq,
rosteen,
nmearl and
keflavich
as code owners
kecnry
reviewed
Sep 11, 2023
Codecov Report
@@ Coverage Diff @@
## main #1078 +/- ##
==========================================
- Coverage 70.72% 70.71% -0.02%
==========================================
Files 64 64
Lines 4485 4490 +5
==========================================
+ Hits 3172 3175 +3
- Misses 1313 1315 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rosteen
reviewed
Sep 11, 2023
| @@ -377,7 +382,7 @@ def fit_lines(spectrum, model, fitter=fitting.LevMarLSQFitter(calc_uncertainties | |||
|
|
|||
| def _fit_lines(spectrum, model, fitter=fitting.LevMarLSQFitter(calc_uncertainties=True), | |||
| exclude_regions=None, weights=None, window=None, get_fit_info=False, | |||
| ignore_units=False, **kwargs): | |||
| ignore_units=False, filter_non_finite=False, **kwargs): | |||
There was a problem hiding this comment.
I think you'll need to add filter_non_finite to the kwargs in the LevMarLSQFitter, looks like tests are failing because other fitters don't expect that keyword argument.
There was a problem hiding this comment.
ah good point, I thought I caught this by setting it to False when the fitter isn't LevMarLSQFitter but those fitters won't expect the flag at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the 'filter_non_finite' flag to specutils.fitting.fit_lines. By default, this flag is False, and it can only be True if the fitter is a
LevMarLSQFitter. This fixes an issue when there are non-finite values in the weights array, and allows the fit to proceed with these filtered out.