Started adding support for allowing dask arrays as input #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrofrog
force-pushed
the
dask-input-output
branch
from
5c2f975
to
1689e22
Compare
astrofrog
commented
May 18, 2023
Codecov Report
@@ Coverage Diff @@
## main #352 +/- ##
==========================================
+ Coverage 92.39% 92.50% +0.10%
==========================================
Files 24 24
Lines 828 840 +12
==========================================
+ Hits 765 777 +12
Misses 63 63
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
astrofrog
commented
May 18, 2023
astrofrog
force-pushed
the
dask-input-output
branch
from
d99bb49
to
3aeb27a
Compare
Cadair
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for specifying the input data as a dask array - this covers only the general case mentioned in #362 of Input where all dimensions are to be reprojected
As mentioned in #362, the general case requires us to write out the dask array to disk and reload it as a Numpy memmap array. There will be ways of making common use cases more efficient as outlined in #362 but for now this PR implements the general approach.