Skip to content

Commit

Permalink
Small update to SceneMaker, making it more explicit that SceneMaker e…
Browse files Browse the repository at this point in the history
…xtends, rather than replaces, GroupMaker
  • Loading branch information
Onoddil committed Apr 22, 2019
1 parent 8d7b5ed commit 753ca3e
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
9 changes: 8 additions & 1 deletion docs/psf_spec/scene_maker.rst
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ is therefore a work in progress and should be considered as such.

However, the block will likely involve an additional column or variable attributed
to each source in the input `~astropy.table.Table` indicating whether sources are
stars or more extended objects. This column will be used in conjunction with
stars or more extended objects. This column will be used in conjunction with
``SingleObjectModel``, which already has the framework to accept ``object_type`` which
allows for individual extended sources to be handled, depending on the specific
class used for the specific purpose. The given list of single object models allowed
Expand All @@ -15,3 +15,10 @@ source classes (stars, galaxies, etc.) as ``SceneMaker`` uses to group and merge
detected sources into point sources or extended objects. The block must also handle
the possibility of merging several point sources into an extended object and vice
versa.

SceneMaker should be considered an extension of GroupMaker, and will likely accept
outputs from that block. Sources grouped together by GroupMaker will subsequently
be assigned as multiple single sources or one larger, extended source erroneously split
up by the Finder, or some combination of the two. This information will then be used by
SingleObjectModel to fit the grouped sources as either individual point sources or
extended sources, based on ``object_type``.
2 changes: 1 addition & 1 deletion docs/psf_spec/single_object_model.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ effects of the PSF, extending the ``psf_model`` block of the PSF
fitting routine to include non-point sources. This method may be subject
to API changes in future versions and should not be considered final.

This block is an additional step between the PSF (or PRF)
This block is an additional step between the PSF (or PRF)
`~astropy.modeling.Fittable2DModel` and the
`~astropy.modeling.fitting.Fitter` instance, to allow for cases
where the images being fit contain sources other than point sources. In
Expand Down

0 comments on commit 753ca3e

Please sign in to comment.