MAINT: Use pathlib to manage paths #83
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think doc warning is related: |
Cadair
reviewed
Feb 27, 2024
| @@ -86,23 +87,24 @@ def write_if_different(filename, data): | |||
|
|
|||
| Parameters | |||
| ---------- | |||
| filename : str | |||
| filename : str | PathLike | |||
There was a problem hiding this comment.
I suspect this is the root of the doc fail, this needs to be a fully qualified thing like os.PathLike or whatever it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still WIP and I'm still not a 100% sure if we should do this as it seems like setuptools
Extensionitself doesn't really supportPathobjects. The src paths needs to be strings https://setuptools.pypa.io/en/latest/userguide/ext_modules.html#setuptools.Extension