For commenting on 01-00-Understanding-an-astronomical-CCD-image.ipynb (part of review-ee0cbc6) #105
Conversation
|
Check out this pull request on ReviewNB: https://app.reviewnb.com/mwcraig/ccd-reduction-and-photometry-guide/pull/105 You'll be able to see visual diffs and write comments on notebook cells. Powered by ReviewNB. |
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "## Counts, photons, and electrons\n", |
There was a problem hiding this comment.
I think the guide is very good in terms of coverage and presentation, especially in the hands-on examples present. However, I really would want to see a bit more of the background information, such as to provide the rationale or the motivation for the performance of the tasks concerned.
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "An astronomical image like the one shown below is essentually a two-dimensional\n", |
There was a problem hiding this comment.
Should this cover other image artifacts like saturation trails and diffraction spikes?
There was a problem hiding this comment.
Yes, it should, thanks for the suggestion!
There was a problem hiding this comment.
FYI, I've added an issue as a reminder to add this: https://github.com/mwcraig/ccd-reduction-and-photometry-guide/issues/138
I'm going to close this commenting pull request in preparation for publishing a revised version (it also includes that typo fix you caught).
mwcraig
deleted the
review-ee0cbc6/01-00-Understanding-an-astronomical-CCD-image.ipynb
branch
No description provided.