Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAIA: Due to the new tap 9.8.0, functions return uncompressed FITS/ECSV files #2983

Conversation

cosmoJFH
Copy link

@cosmoJFH cosmoJFH commented Apr 6, 2024

Due to the latest changes in the TAP library (version 0.9.8) used in the Gaia Archive, for the functions that return files in FITS/ECSV format, these files are now provided as uncompressed files.

cc @esdc-esac-esa-int

jira: GAIAPCR-1317

@cosmoJFH cosmoJFH changed the title GAIA: Due to the new tap 9 8 0, functions return files uncompressed FITS/ECSV files GAIA: Due to the new tap 9 8 0, functions return uncompressed FITS/ECSV files Apr 6, 2024
Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.82%. Comparing base (886817e) to head (8084c7d).
Report is 53 commits behind head on main.

❗ Current head 8084c7d differs from pull request most recent head 6599113. Consider uploading reports for the commit 6599113 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2983      +/-   ##
==========================================
- Coverage   66.83%   66.82%   -0.01%     
==========================================
  Files         237      237              
  Lines       18327    18324       -3     
==========================================
- Hits        12248    12245       -3     
  Misses       6079     6079              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bsipocz
Copy link
Member

bsipocz commented Apr 7, 2024

I suspect the oldest version CI failure will go away once #2966 is merged, so I would hold up merging this until then (that PR should go in early next week).

@bsipocz bsipocz added the gaia label Apr 7, 2024
@bsipocz bsipocz added this to the v0.4.8 milestone Apr 7, 2024
@cosmoJFH cosmoJFH changed the title GAIA: Due to the new tap 9 8 0, functions return uncompressed FITS/ECSV files GAIA: Due to the new tap 9.8.0, functions return uncompressed FITS/ECSV files Apr 7, 2024
@bsipocz bsipocz force-pushed the ESA_gaia_tap_9_8_0_update_retrieved_files branch from 8084c7d to 6599113 Compare April 30, 2024 01:34
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased to pick up the changes to the CI, and those indeed fixed the failures.

Thanks!

Also, @cosmoJFH if you add the email address you make these commits to your github profile they will properly show up as yours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants