Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simbad: refactor to use TAP #2954

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Simbad: refactor to use TAP #2954

wants to merge 23 commits into from
+4,643 −3,236

Commits on Jun 3, 2024

  1. refactor: simbad query methods now call query_tap internally 

    - add construct_query method that reads the columns_in_output, join, and criteria attirbutes

- support the removed query_criteria method functionnalities by adding a criteria attribute that should be a valid adql clause. The utils CriteriaTranslator can translate between the old and new syntax.

- make ROW_LIMIT = -1 to return all lines because TOP 0 or maxrec = 0 are the dedicated way to retrieve table metadata in TAP

- fix usage of lru_cache on class methods that can cause memory leaks (see bugbear rule B019)
    @ManonMarchand
    ManonMarchand committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    793e755 View commit details
    Browse the repository at this point in the history

  2. lint: add yacc and lex automatically generated files to flake8 ignore 

    these are the files of the simbad.utils.CriteriaTranslator parser
    @ManonMarchand
    ManonMarchand committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    e7d9dc2 View commit details
    Browse the repository at this point in the history

  3. fix: add a __call__ definition to make BaseVOQuery behave as BaseQuery

    @ManonMarchand
    ManonMarchand committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    a09561c View commit details
    Browse the repository at this point in the history

  4. add query_criteria_fialds.json 

    and move from os to pathlib
    @ManonMarchand
    ManonMarchand committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    9d2f085 View commit details
    Browse the repository at this point in the history

  5. docs: document simbad refactoring

    @ManonMarchand
    ManonMarchand committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    fe0d76e View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. fix: propagate simbad changes to jwst module 

    this commit also adds a patch to simbad's query_objects in the tests
    @ManonMarchand
    ManonMarchand committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    af88fd3 View commit details
    Browse the repository at this point in the history

  2. docs: propagate simbad changes into the general documentation

    @ManonMarchand
    ManonMarchand committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    9eb0e01 View commit details
    Browse the repository at this point in the history

  3. docs: simbad cache works differently now 

    simbad calls lru_cache from python core library, so no cache_location
    @ManonMarchand
    ManonMarchand committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    9c706eb View commit details
    Browse the repository at this point in the history

  4. tests: add simbad_output_options to path_tests

    @ManonMarchand
    ManonMarchand committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    b037e2f View commit details
    Browse the repository at this point in the history

  5. refactor: remove utilities for the former sim script queries

    @ManonMarchand
    ManonMarchand committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    88dc555 View commit details
    Browse the repository at this point in the history

  6. feat: add bibcodelist to possible outputs

    @ManonMarchand
    ManonMarchand committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    e5a7aa5 View commit details
    Browse the repository at this point in the history

  7. test: complete coverage of simbad utils

    @ManonMarchand
    ManonMarchand committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    b6a9057 View commit details
    Browse the repository at this point in the history

  8. tests: improve coverage for the tests without remote access

    @ManonMarchand
    ManonMarchand committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    9247476 View commit details
    Browse the repository at this point in the history

  9. docs: update simbad's doc

    @ManonMarchand
    ManonMarchand committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    903ea82 View commit details
    Browse the repository at this point in the history

  10. fix: typo in vizier link

    @ManonMarchand
    ManonMarchand committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    92d0470 View commit details
    Browse the repository at this point in the history

  11. feat: add ROW_LIMIT as a settable property

    @ManonMarchand
    ManonMarchand committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    aa7b50d View commit details
    Browse the repository at this point in the history

  12. rename 'add_to_output' into 'add_output_columns'

    @ManonMarchand
    ManonMarchand committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    576dba9 View commit details
    Browse the repository at this point in the history

  13. docs: edit version of deprecation

    @ManonMarchand
    ManonMarchand committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    73fa195 View commit details
    Browse the repository at this point in the history

  14. feat: reduce API changes

    @ManonMarchand
    ManonMarchand committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    9f6171b View commit details
    Browse the repository at this point in the history

  15. docs: edits on votable fields utils

    @ManonMarchand
    ManonMarchand committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    283c640 View commit details
    Browse the repository at this point in the history

  16. docs: add changelog 

    Co-authored-by: Adam Ginsburg <keflavich@gmail.com>
    @ManonMarchand @keflavich
    ManonMarchand and keflavich committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    8fedab5 View commit details
    Browse the repository at this point in the history

  17. fix: rename typed_id into user_specified_id

    @ManonMarchand
    ManonMarchand committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    98ae3b4 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. feat: add get_query_payload for the methods using TAP

    @ManonMarchand
    ManonMarchand committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    c1dfe1a View commit details
    Browse the repository at this point in the history