Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping python 3.7 support #2742

Closed
bsipocz opened this issue May 26, 2023 · 10 comments · Fixed by #2966
Closed

Dropping python 3.7 support #2742

bsipocz opened this issue May 26, 2023 · 10 comments · Fixed by #2966

Comments

@bsipocz
Copy link
Member

bsipocz commented May 26, 2023

Before I drop support, would like to see some input from the bigger teams in astroquery. Would you mind if we drop it?
(most big packages are dropping 3.8 (numpy, scipy, etc) in the upcoming releases, and dropped 3.7 a while ago already, and some of the infrastructure packages we use are dropping support, too. So while we can keep going, it's a tiny bit easier if we could do it without workarounds, or to use nice new features)

@astropy/astroquery-archive-maintainers

@bsipocz bsipocz added this to the v0.4.7 milestone May 26, 2023
@keflavich
Copy link
Contributor

I'm good with that.

@jd-au
Copy link
Contributor

jd-au commented May 29, 2023

+1 Looks like 3.7 loses security support very soon, so its a good time to drop support.

@andamian
Copy link

Yes, that works for 3.7 since it will reach its end of life soon.

We found it easier to justify to our users (and convince them to update their environments) if we follow Python release schedule but we don't rush it until something stops working. We have to be mindful that users sometimes run software on systems that are out of their control and a Python upgrade might require an OS upgrade with sys admin intervention and other complications.

@ceb8
Copy link
Member

ceb8 commented May 30, 2023

I'm good with this.

@mkelley
Copy link
Contributor

mkelley commented May 30, 2023

Sounds good to me.

@bsipocz
Copy link
Member Author

bsipocz commented May 30, 2023

We have to be mindful that users sometimes run software on systems that are out of their control and a Python upgrade might require an OS upgrade with sys admin intervention and other complications.

Yes, that's why I'm not suggesting to follow drop schedule the big libraries follow and endorse. But at some point we need to start dropping as the infrastructure we're using is also slowly doing it. (nothing extra urgent just yet)

@jaymedina
Copy link
Contributor

jaymedina commented May 30, 2023

This seems reasonable. We've already dropped support for 3.7 in Astrocut too (which tesscut/zcut/hapcut wrap around).

@jespinosaar
Copy link
Contributor

Hi all, I think we can drop the support, yes, I have been testing with our modules and Python >= 3.8 and seems to be working.

@bsipocz
Copy link
Member Author

bsipocz commented Jun 7, 2023

@jespinosaar - it's less about testing, more about whether you know your end users being stuck on an old version?

@bsipocz
Copy link
Member Author

bsipocz commented Jun 7, 2023

OK, so my tentative plan is then to do this once I tag a v0.4.7 release, sometimes over the summer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants