Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for issue 15782: Remove needless functions from an io.ascii test helper file #16266

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

stefanarseneau
Copy link

@stefanarseneau stefanarseneau commented Apr 3, 2024

EDIT: close #15839

resolving issue, fix #15782

replaced all calls of:
assert_equal() -> np.testing.assert_equal()
assert_almost_equal() -> np.testing.assert_allclose()
assert_true(a) -> assert a
in the following files:
astropy/io/ascii/tests/test_c_reader.py
astropy/io/ascii/tests/test_cds.py
astropy/io/ascii/tests/test_rst.py
astropy/io/ascii/tests/test_types.py
astropy/io/ascii/tests/test_read.py
astropy/io/ascii/tests/test_fixedwidth.py
astropy/io/ascii/tests/test_cds_header_from_readme.py

Description

This pull request is to address ...

Fixes #

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

replaced all calls of:
    assert_equal() -> np.testing.assert_equal()
    assert_almost_equal() -> np.testing.assert_allclose()
    assert_true(a) -> assert a
in the following files:
    astropy/io/ascii/tests/test_c_reader.py
    astropy/io/ascii/tests/test_cds.py
    astropy/io/ascii/tests/test_rst.py
    astropy/io/ascii/tests/test_types.py
    astropy/io/ascii/tests/test_read.py
    astropy/io/ascii/tests/test_fixedwidth.py
    astropy/io/ascii/tests/test_cds_header_from_readme.py
Copy link

github-actions bot commented Apr 3, 2024

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Astropy 👋 and congratulations on your first pull request! 🎉

A project member will respond to you as soon as possible; in the meantime, please have a look over the Checklist for Contributed Code and make sure you've addressed as many of the questions there as possible.

If you feel that this pull request has not been responded to in a timely manner, please send a message directly to the development mailing list. If the issue is urgent or sensitive in nature (e.g., a security vulnerability) please send an e-mail directly to the private e-mail feedback@astropy.org.

@neutrinoceros
Copy link
Contributor

Thank you for your effort, however, please note that there is already an other PR opened to fix #15782 that we are already invested in reviewing (#15839).

@pllim pllim added this to the v7.0.0 milestone Apr 4, 2024
@eerovaher eerovaher added testing and removed Close? labels Apr 12, 2024
@eerovaher
Copy link
Member

It is true that there already is another pull request addressing the same issue, but there is little reason to believe it will ever be finished, so this shouldn't be closed as a duplicate. That being said, this needs to be rewritten to a large extent so that it would follow the updated instructions in #15782.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove needless functions from an io.ascii test helper file
4 participants