New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix for issue 15782: Remove needless functions from an io.ascii test helper file #16266
base: main
Are you sure you want to change the base?
Bugfix for issue 15782: Remove needless functions from an io.ascii test helper file #16266
Conversation
replaced all calls of: assert_equal() -> np.testing.assert_equal() assert_almost_equal() -> np.testing.assert_allclose() assert_true(a) -> assert a in the following files: astropy/io/ascii/tests/test_c_reader.py astropy/io/ascii/tests/test_cds.py astropy/io/ascii/tests/test_rst.py astropy/io/ascii/tests/test_types.py astropy/io/ascii/tests/test_read.py astropy/io/ascii/tests/test_fixedwidth.py astropy/io/ascii/tests/test_cds_header_from_readme.py
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to Astropy 👋 and congratulations on your first pull request! 🎉
A project member will respond to you as soon as possible; in the meantime, please have a look over the Checklist for Contributed Code and make sure you've addressed as many of the questions there as possible.
If you feel that this pull request has not been responded to in a timely manner, please send a message directly to the development mailing list. If the issue is urgent or sensitive in nature (e.g., a security vulnerability) please send an e-mail directly to the private e-mail feedback@astropy.org.
It is true that there already is another pull request addressing the same issue, but there is little reason to believe it will ever be finished, so this shouldn't be closed as a duplicate. That being said, this needs to be rewritten to a large extent so that it would follow the updated instructions in #15782. |
EDIT: close #15839
resolving issue, fix #15782
replaced all calls of:
assert_equal() -> np.testing.assert_equal()
assert_almost_equal() -> np.testing.assert_allclose()
assert_true(a) -> assert a
in the following files:
astropy/io/ascii/tests/test_c_reader.py
astropy/io/ascii/tests/test_cds.py
astropy/io/ascii/tests/test_rst.py
astropy/io/ascii/tests/test_types.py
astropy/io/ascii/tests/test_read.py
astropy/io/ascii/tests/test_fixedwidth.py
astropy/io/ascii/tests/test_cds_header_from_readme.py
Description
This pull request is to address ...
Fixes #