-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLD: build with numpy 2.0.0rc1 (or newer) #16252
BLD: build with numpy 2.0.0rc1 (or newer) #16252
Conversation
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
👋 Thank you for your draft pull request! Do you know that you can use |
I put the milestone at 6.1, but am wondering about labels. What's-new and a changelog entry both seem reasonable (likely just I'm actually slightly surprised this all works without |
that's because pyerfa isn't a build-time dependency to astropy, so we're already able to compile astropy, but you're right that we need new wheels for pyerfa for astropy to work with numpy 2.0 at runtime. Anyway, I just opened a similar PR on pyerfa |
I also just added a changelog fragment as requested |
I wasn't sure what was the agreed plan w.r.t. v6.1 vs numpy 2.0 but usually we don't pin to unstable or pre-release. I will change this to draft for now and defer to @astropy/astropy-project-release-team . Thanks for your help and patience! |
For context see bullet point 4 from numpy/numpy#24300 |
I think we do need to temporarily pin to 2.0.0rc1 in pyproject.toml to release the v6.1 wheels before Numpy 2.0.0 final. |
As for the pyerfa version, I'm not quite sure we should set the minimum version here, or whether it is better to set it in the processes that create the wheels. It is not that astropy requires numpy 2.0 to build; it only requires it if you also want to run on 2.0. |
That's correct. However I don't quite get the objection here; build-time dependencies from
So, who would this be actually affecting negatively ? |
OK thanks for the feedback all. I took it back out of draft. But might want a follow-up issue to pin to numpy stable again when we can. |
e119cb9
to
f8e23cc
Compare
Yes we need to build wheels with Numpy 2.0 (rc1 currently) to get wheels that are runtime compatible with both Numpy 1.x and 2.0. And every package that has C/Cython extensions using the Numpy C API needs to do the same. |
Do you want to trigger a dev wheel build now or you ok to wait one day? Thanks, all! |
Description
Now that numpy 2.0.0 pre-releases reached ABI statbility, we can start building wheels against it.
This is required (but possibly not sufficient) to close #16167