Merge pull request #16173 from eerovaher/rm-make-getter

Remove `astropy.coordinates.representation.base._make_getter()`

astropy/coordinates/representation/base.py

@@ -517,25 +517,6 @@ def __repr__(self):
         )
 
 
-def _make_getter(component):
-    """Make an attribute getter for use in a property.
-
-    Parameters
-    ----------
-    component : str
-        The name of the component that should be accessed.  This assumes the
-        actual value is stored in an attribute of that name prefixed by '_'.
-    """
-    # This has to be done in a function to ensure the reference to component
-    # is not lost/redirected.
-    component = "_" + component
-
-    def get_component(self):
-        return getattr(self, component)
-
-    return get_component
-
-
 class RepresentationInfo(BaseRepresentationOrDifferentialInfo):
     @property
     def _represent_as_dict_attrs(self):
@@ -650,7 +631,7 @@ def __init_subclass__(cls, **kwargs):
                     cls,
                     component,
                     property(
-                        _make_getter(component),
+                        lambda self, comp=f"_{component}": getattr(self, comp),
                         doc=f"The '{component}' component of the points(s).",
                     ),
                 )
@@ -1301,7 +1282,7 @@ def __init_subclass__(cls, **kwargs):
                     cls,
                     component,
                     property(
-                        _make_getter(component),
+                        lambda self, comp=f"_{component}": getattr(self, comp),
                         doc=f"Component '{component}' of the Differential.",
                     ),
                 )