New fits tables #564
Open
New fits tables #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luthienliu
commented
Jul 6, 2022
•
luthienliu
commented
- Check the box to confirm that you are familiar with the contributing guidelines and/or indicate (check the box) that you are familiar with our contributing workflow.
- Confirm that any contributed tutorials contain a complete Introduction which includes an Author list, Learning Goals, Keywords, Companion Content (if applicable), and a Summary.
- Check the box to confirm that you are familiar with the Astropy community code of conduct and you agree to follow the CoC.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
mwcraig
reviewed
Jul 20, 2022
There was a problem hiding this comment.
Overall, this is much improved, thanks for opening this @luthienliu!
I have a couple of suggestions in the text. Though I read the notebook I didn't actually try running it, but our automated tests should catch any errors there.
Co-authored-by: Matt Craig <mattwcraig@gmail.com>
for more information, see https://pre-commit.ci
eblur
reviewed
Aug 12, 2022
eblur
reviewed
Aug 12, 2022
eblur
reviewed
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.