Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tutorial to calculate radial velocity from multiple measurements #550

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

alexbinks
Copy link

This tutorial is designed to assess the multiplicity status of a
star and calculate a "final" radial velocity for stars when there
are several (> 2) individual measurements. Whilst intended for
RV measurements, the method can be applied for any
parameter that needs to be weighted from different sources.
Principally the program:

  1. reads in a table of RV measurements for any set of stars
  2. makes a decision on whether the star is multiple or likely single
  3. calculates a final RV from the individual measurements.
  • Check the box to confirm that you are familiar with the contributing guidelines and/or indicate (check the box) that you are familiar with our contributing workflow.
  • Confirm that any contributed tutorials contain a complete Introduction which includes an Author list, Learning Goals, Keywords, Companion Content (if applicable), and a Summary.
  • Check the box to confirm that you are familiar with the Astropy community code of conduct and you agree to follow the CoC.

This tutorial is designed to assess the multiplicity status of a
star and calculate a "final" radial velocity for stars when there
are several (> 2) individual measurements. Principally the program:
1) reads in a table of RV measurements for any set of stars
2) makes a decision on whether the star is multiple or likely single
3) calculates a final RV from the individual measurements.
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@alexbinks alexbinks marked this pull request as draft April 12, 2022 18:16
@hamogu
Copy link
Member

hamogu commented Apr 12, 2022

Thanks for contributing! This looks interesting, but I think you might want to see if the indexing logic can be simplified a bit. At least I don't understand it - but maybe that's just because I don't know that much about the topic.

alexbinks and others added 3 commits April 13, 2022 20:55
on measuring radial velocities. The major modifications are that
we now use numpy matrices rather than itertools which is easier to
read and runs faster than the previous method.
@kelle
Copy link
Member

kelle commented Apr 14, 2022

This looks really promising! Thanks so much for the contribution and we'll work on giving it a robust review ASAP. I'm also going to start a thread in the #learn channel on slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants