-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quantity 2.0 #91
base: main
Are you sure you want to change the base?
Quantity 2.0 #91
Conversation
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
I totally missed this one, so I am confused why there is a APE 23 and APE 25 here. And why report is in PDF instead of Markdown. Is this related to the following? |
I'll clean that up.
The report was for the Moore grant, not the APE. I'm including the PDF to eventually turn into an APE, written in Markdown. |
@nstarman, I think this looks really good so far, I'm quite excited to work with other arrays inside Quantity! I was wondering if you have given any thought to supporting arrays with labeled axes (e.g. xarray) during this effort? I think supporting xarray (or the other way around, xarray supporting Quantity) is really important going forward, and I think it's worth considering adding first-class support this feature for Quantity 2.0. |
xarray already has support for units via https://github.com/xarray-contrib/pint-xarray, so making |
I guess it depends on how we want to interact with the rest of the astropy ecosystem, for example: how can we make |
Support for x-array has to use their framework, which is how |
PDF link: https://github.com/nstarman/astropy-APEs/blob/units-quantity-2.0/APE25/report.pdf