-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observable_interval
function added and months_observable
aliased
#531
Open
tygger7
wants to merge
7
commits into
astropy:main
Choose a base branch
from
tygger7:observable_interval
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Nov 2, 2022
-
added observable_interval func
added a generic function of `months_observable` called `observable_interval` that takes 'days','weeks',or 'months' and returns the same results.
Configuration menu - View commit details
-
Copy full SHA for bdc099a - Browse repository at this point
Copy the full SHA bdc099aView commit details -
old version was not including the 31st of December in its calculations for `months_observable`. This was the only function to use this, so it is an easy update, and with `observable_interval` added is needed.
Configuration menu - View commit details
-
Copy full SHA for 64c98d9 - Browse repository at this point
Copy the full SHA 64c98d9View commit details -
observable_interval
aliases + output readability updateMade `months_observable` an alias of `observable_interval` to maintain backwards compatibility. Also added `weeks_observable` and `days_observable` aliases. I also made a small change to `observable_interval` to enhance output readability in the case a target is never visible given the constraints. (would have been "set()" now is "{}")
Configuration menu - View commit details
-
Copy full SHA for 7f57b04 - Browse repository at this point
Copy the full SHA 7f57b04View commit details -
Configuration menu - View commit details
-
Copy full SHA for 482780b - Browse repository at this point
Copy the full SHA 482780bView commit details
Commits on Nov 4, 2022
-
code style changes for tox checks
fixed the issues that were noted with the tox check
Configuration menu - View commit details
-
Copy full SHA for 7d42c9d - Browse repository at this point
Copy the full SHA 7d42c9dView commit details
Commits on Nov 7, 2022
-
minor white space errors removed in aliased functions and between aliased function
Configuration menu - View commit details
-
Copy full SHA for dd6d9da - Browse repository at this point
Copy the full SHA dd6d9daView commit details
Commits on Dec 5, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c312f5a - Browse repository at this point
Copy the full SHA c312f5aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.