Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SRT styling and bold/underline in VTT #96

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

kloon15
Copy link

@kloon15 kloon15 commented Oct 19, 2023

Hows this code looking like? Feedback appreciated.

Copy link
Owner

@asticode asticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also fix webvtt tests and add srt/webvtt tests for bold/italic/underline/color?

You can either directly use testdata/example-in.srt in TestSRT for instance, or write a new test specifically for html tags.

srt.go Show resolved Hide resolved
srt.go Outdated Show resolved Hide resolved
srt.go Outdated Show resolved Hide resolved
srt.go Outdated Show resolved Hide resolved
srt.go Outdated Show resolved Hide resolved
webvtt.go Outdated Show resolved Hide resolved
subtitles.go Outdated Show resolved Hide resolved
@asticode
Copy link
Owner

Could you remove the SSA-related commits from this PR?

I don't want to mix different things in the same PR.

Thanks

@kloon15
Copy link
Author

kloon15 commented Oct 29, 2023

Could you remove the SSA-related commits from this PR?

I don't want to mix different things in the same PR.

Thanks

I done nothing to SSA, its for supporting SRT position tags which use ASS tags so figured its easier to call em that. TBH im not sure what tags most players support, but position is pretty popular.

@asticode
Copy link
Owner

I done nothing to SSA, its for supporting SRT position tags which use ASS tags so figured its easier to call em that. TBH im not sure what tags most players support, but position is pretty popular.

OK, then could you remove the 2 commits handling ASS tags from this PR? I'd rather have this change in a separate PR.

Thanks!

@kloon15
Copy link
Author

kloon15 commented Oct 31, 2023

Sure will do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants