-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app_speech_utils.c: Add horses to speech engines. #594
base: master
Are you sure you want to change the base?
Conversation
Speech Engines can now have multiple horses inside that race to get you results from different backends. UserNote: The various Speech...() dialplan applications and the SPEECH_TEXT function now support the use of carets to control the horses in your engines. SpeechCreate(engine^horse1) SpeechCreate(engine^horse2) SpeechBackground(audio,,,horse1^horse2) SPEECH_TEXT(0^horse1) SPEECH_TEXT(0^horse2) SpeechDestroy(engine^horse1) SpeechDestroy(engine^horse2) Resolves: asterisk#593
I don't agree with the use of "horses" in this. From a user facing perspective it doesn't really make sense and is not intuitive. |
REMINDER: If this PR applies to other branches, please add a comment with the appropriate "cherry-pick-to" headers as per the Create a Pull Request process. If you don't want it cherry-picked, please add a comment with If, after adding "cherry-pick-to" comments, you change your mind, please edit the comment to DELETE the header lines and add The currently active branches are now 18, 20, 21 and master. |
cherry-pick-to: none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think the horse is dead.
The use of the word "engine" in software comes directly from cars. And car engines have horse power. But "power" alone is too generic. (Also considered was powertrain but that is too long.) |
Maybe "candidate" would be a less controversial name? In my mind the naming is secondary to the merits of the proposed change itself. It may be best to work through that first and then circle back on the name at the end? Just my 2¢. |
Patch needs more work, will convert to draft for now. Thanks y'all for the feedback! |
Speech Engines can now have multiple horses inside that race to get you results from different backends.
UserNote: The various Speech...() dialplan applications and the SPEECH_TEXT function now support the use of carets to control the horses in your engines.
SpeechCreate(engine^horse1)
SpeechCreate(engine^horse2)
SpeechBackground(audio,,,horse1^horse2)
SPEECH_TEXT(0^horse1)
SPEECH_TEXT(0^horse2)
SpeechDestroy(engine^horse1)
SpeechDestroy(engine^horse2)
Resolves: #593