install_prereq: Fix package so asterisk can install on debian buster,bullseye, and bookworm.

[jackdpeterson]

• update list of debian packages to ones that are installable on debian:bullseye
• switch from aptitude to apt-get (so we can get specific error messages when packages aren't found)
• switch for aptitude check to dpkg since that's also built into the docker debian OS image

Other notes: this is a pretty messy script as-is and should probably have those constants split by version of OS. For example, debian bullseye doesn't have the mysql dependency available -- that's replaced w/ mariaDB equivalent client connector library. Furthermore, certain legacy libraries are replaced by newer versions.

[gtjoseph]

A few things...

• Please open a corresponding "improvement" issue and add a "Fixes" or 'Resolves" line to the commit message per Commit Messages
• Is this really docker specific? Doesn't seem so.
• Update the commit message summary line so it's clear that it's only install_prereq that's changing:
  install_prereq: Update for debian:bullseye might be better.
• Add the cherry-pick comment per Code-Contribution
• You might want to list the packages that were actually changed in the commit message.
• How far back in ubuntu and debian versions are the changes still good? If this breaks installing on ubuntu:18 or debian:buster for instance, this would be a problem.

Remember to follow the procedure for force pushing an amended commit described in Code-Contribution.
After you re-push up the commit, don't forget to change the PR description. It doesn't update automatically.

[github-actions]

REMINDER: If this PR applies to other branches, please add a comment with the appropriate "cherry-pick-to" headers as per the Create a Pull Request process.

If you don't want it cherry-picked, please add a comment with cherry-pick-to: none so we don't keep asking.

If, after adding "cherry-pick-to" comments, you change your mind, please edit the comment to DELETE the header lines and add cherry-pick-to: none.

The currently active branches are now 18, 20, 21 and master.

[asteriskteam]

This PR has been marked stale because it has been in "Changes Requested" or "submitter-action-required" state for 28 days or more. Please make the requested changes within 14 days or the PR will be closed.

[jackdpeterson]

✅ Please open a corresponding "improvement" issue and add a "Fixes" or 'Resolves" line to the commit message per Is

this really docker specific? Doesn't seem so.
Correct, updated messaging to reflect that this isn't docker-specific. That's just the environment I was testing in.

✅ Update the commit message summary line so it's clear that it's only install_prereq that's changing

✅ Add the cherry-pick comment per Code-Contribution

✅ You might want to list the packages that were actually changed in the commit message.
-- Added package differences into commit.

How far back in ubuntu and debian versions are the changes still good? If this breaks installing on ubuntu:18 or debian:buster for instance, this would be a problem.
📆 -- Need to test this.

[seanbright]

if ! dpkg -l | awk 'NR > 5 {print $2}' | grep -q ^"${pack}"$; then
    echo "${pack}"
fi

[seanbright]

Actually, it may be as simple as:

dpkg -l "${pack}" >/dev/null 2>&1 || echo "${pack}"

[jackdpeterson]

Hey @seanbright -- your suggestion here isn't quite safe:

cat test.sh

#!/usr/bin/env sh

PACK="SOMETHING_I_DONT_HAVE"

EXISTS=`dpkg -l "${pack}" >/dev/null 2>&1 || echo "${pack}"`
if [ ${EXISTS} -eq 0 ]; then
  echo "${pack}"
fi

./test.sh
./test.sh: 6: [: -eq: unexpected operator

The approach I have is guaranteed to provide a numeric output with the | wc -l

[seanbright]

I think you misunderstood my suggestion. I was suggesting this:

check_installed_debs() {
  for pack in "$@" ; do
    dpkg -l "${pack}" >/dev/null 2>&1 || echo "${pack}"
  done
}

[seanbright]

You're going to have to switch between package lists based on the Debian/Ubuntu version. lsb_release -a gives you some of this info (at least on Ubuntu, I don't know about Debian).

[asteriskteam]

This PR has been marked stale because it has been in "Changes Requested" or "submitter-action-required" state for 28 days or more. Please make the requested changes within 14 days or the PR will be closed.

[jackdpeterson]

@seanbright -- I'd appreciate your feedback on this PR. I've modified my changes to separate out the different debian releases and select the packages there. This should make this more maintainable going forward and could be used as a pattern for other distributions that change/modify/remove packages over time.

In-scope: debian based OS's.

• test debian:buster (10)
• test debain:bullseye (11)
• test debian:bookworm (12)

Dockerfiles I used to test

Commands to build:

Buster

docker build -t asterisk:buster -f Dockerfile-debian-buster .

Bullseye

docker build -t asterisk:bullseye -f Dockerfile-debian-bullseye .

Bookworm

docker build -t asterisk:bookworm -f Dockerfile-debian-bookworm .

Initially I tried compiling this on a Macbook Pro w/ an M1 chip; and compilation of asterisk failed there. What did work was launching a C5.2xlarge instance on AWS EC2 running Ubuntu 22.04 w/ git and docker.io installed.

[jackdpeterson]

Could use a little bit of guidance on the failing tests here. Not making any changes to PJSIP.

[jcolp]

The install_prereq script is not used, the failing tests can be ignored for this PR.

[jackdpeterson]

Fixing one more issue; ensuring that dpkg -l section properly gets converted to a number always w/ wc -l

#24 1.203 ./contrib/scripts/install_prereq: 245: [: -eq: unexpected operator
#24 1.208 ./contrib/scripts/install_prereq: 245: [: -eq: unexpected operator
#24 1.213 ./contrib/scripts/install_prereq: 245: [: -eq: unexpected operator
#24 1.218 ./contrib/scripts/install_prereq: 245: [: Illegal number: libjansson-dev

[seanbright]

Could this be simplified with a case statement? Something like:

case "$(cut -f1 -d. /etc/debian_version)" in
  10) extra_packs=$(check_installed_debs $PACKAGES_DEBIAN_BUSTER) ;;
  11) extra_packs=$(check_installed_debs $PACKAGES_DEBIAN_BULLSEYE) ;;
  12) extra_packs=$(check_installed_debs $PACKAGES_DEBIAN_BOOKWORM) ;;
  *)  extra_packs=$(check_installed_debs $PACKAGES_DEBIAN) ;;
esac

[jackdpeterson]

That's pretty. I'll update the PR and test it to reflect that concept.

[asteriskteam]

This PR has been marked stale because it has been in "Changes Requested" or "submitter-action-required" state for 28 days or more. Please make the requested changes within 14 days or the PR will be closed.