Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sig_analog: Add Call Waiting Deluxe support. #272

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sig_analog: Add Call Waiting Deluxe support. #272

wants to merge 1 commit into from

Conversation

InterLinked1
Copy link
Contributor

Adds support for Call Waiting Deluxe options to enhance the current call waiting feature.

As part of this change, a mechanism is also added that allows a channel driver to queue an audio file for Dial() to play, which is necessary for the announcement function.

ASTERISK-30373 #close

Imported from Gerrit: https://gerrit.asterisk.org/c/asterisk/+/19748

Resolves: #271

@asterisk-org-access-app
Copy link

REMINDER: If this PR applies to other branches, please add a comment with the appropriate "cherry-pick-to" headers as per the Create a Pull Request process.

If you don't want it cherry-picked, please add a comment with cherry-pick-to: none so we don't keep asking.

If, after adding "cherry-pick-to" comments, you change your mind, please edit the comment to DELETE the header lines and add cherry-pick-to: none.

The currently active branches are now 18, 20, 21 and master.

@asterisk-org-access-app asterisk-org-access-app bot requested a review from a team August 24, 2023 14:13
@InterLinked1
Copy link
Contributor Author

cherry-pick-to: 18
cherry-pick-to: 20
cherry-pick-to: 21

@gtjoseph gtjoseph force-pushed the master branch 7 times, most recently from b15287c to 1862a36 Compare September 5, 2023 19:35
@InterLinked1
Copy link
Contributor Author

@asteriskteam Would someone mind giving this review in particular a look soon, if they have time? Don't want to nag, but because of the monolithic architecture of chan_dahdi, it's very difficult to do concurrent development for chan_dahdi so things have to be serialized. Thanks!

jcolp
jcolp requested changes Nov 2, 2023
View reviewed changes
include/asterisk/channel.h Outdated Show resolved Hide resolved
@jcolp
Copy link
Member

jcolp commented Nov 2, 2023

@asteriskteam Would someone mind giving this review in particular a look soon, if they have time? Don't want to nag, but because of the monolithic architecture of chan_dahdi, it's very difficult to do concurrent development for chan_dahdi so things have to be serialized. Thanks!

The reality is that community members have no interest in reviewing these kind of changes, and personally I put such changes at the bottom of my todo list. You can continue to do development of chan_dahdi for your needs/interests/purposes, but the review times here are likely to continue to be a long time.

jcolp
jcolp requested changes Nov 7, 2023
View reviewed changes
include/asterisk/frame.h Outdated Show resolved Hide resolved
@InterLinked1
Copy link
Contributor Author

@jcolp Sorry to prod again, but would you mind taking another look at this when you have time? I realize there are a lot of patches sitting, but since this one is adding control frames and such, it would be really helpful if this could move along to avoid ABI headaches - thanks!

jcolp
jcolp requested changes Mar 18, 2024
View reviewed changes
Copy link
Member

@jcolp jcolp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, unless someone else gives this a review I will not be accepting the change. You'll have to convince someone else to review this as well.

apps/app_dial.c Outdated Show resolved Hide resolved
channels/chan_iax2.c Outdated Show resolved Hide resolved
@InterLinked1
sig_analog: Add Call Waiting Deluxe support.
4356f16 
Adds support for Call Waiting Deluxe options to enhance
the current call waiting feature.

As part of this change, a mechanism is also added that
allows a channel driver to queue an audio file for Dial()
to play, which is necessary for the announcement function.

ASTERISK-30373 #close

Resolves: asterisk#271
@InterLinked1 InterLinked1 requested a review from jcolp March 18, 2024 17:33
@asteriskteam asteriskteam requested a review from a team March 18, 2024 17:58
@asteriskteam
Copy link
Contributor

This PR has been marked stale because it has been in "Changes Requested" or "submitter-action-required" state for 28 days or more. Please make the requested changes within 14 days or the PR will be closed.

@asteriskteam
Copy link
Contributor

This PR has been closed because it has been in "Changes Requested" or "submitter-action-required" state for more than 42 days.

@jcolp jcolp reopened this May 1, 2024
@asteriskteam
Copy link
Contributor

This PR has been marked stale because it has been in "Changes Requested" or "submitter-action-required" state for 28 days or more. Please make the requested changes within 14 days or the PR will be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcolp jcolp Awaiting requested review from jcolp

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
pr-submit-tests-failed stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[new-feature]: sig_analog: Add Call Waiting Deluxe support.
3 participants
@InterLinked1 @jcolp @asteriskteam