Handle null versions in dependencies

- Added test in WalkerFacts #1161
aspnet · Feb 4, 2015 · 31d24b2 · 31d24b2
1 parent bd9d03b
commit 31d24b2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/src/Microsoft.Framework.Runtime/DependencyManagement/Library.cs b/src/Microsoft.Framework.Runtime/DependencyManagement/Library.cs
@@ -63,7 +63,7 @@ public override int GetHashCode()
             {
                 Name = library.Name,
                 IsGacOrFrameworkReference = library.IsGacOrFrameworkReference,
-                VersionRange = new SemanticVersionRange
+                VersionRange = library.Version == null ? null : new SemanticVersionRange
                 {
                     MinVersion = library.Version,
                     VersionFloatBehavior = SemanticVersionFloatBehavior.None

diff --git a/src/Microsoft.Framework.Runtime/DependencyManagement/UnresolvedDependencyProvider.cs b/src/Microsoft.Framework.Runtime/DependencyManagement/UnresolvedDependencyProvider.cs
@@ -18,7 +18,7 @@ public LibraryDescription GetDescription(LibraryRange libraryRange, FrameworkNam
                 {
                     Name = libraryRange.Name,
                     IsGacOrFrameworkReference = libraryRange.IsGacOrFrameworkReference,
-                    Version = libraryRange.VersionRange.MinVersion
+                    Version = libraryRange.VersionRange?.MinVersion
                 },
                 Dependencies = Enumerable.Empty<LibraryDependency>(),
                 Resolved = false

diff --git a/test/Microsoft.Framework.Runtime.Tests/DependencyWalkerFacts.cs b/test/Microsoft.Framework.Runtime.Tests/DependencyWalkerFacts.cs
@@ -162,7 +162,8 @@ public void RejectedDependenciesToNotCarryConstraints()
                 .Package("e", "1.0", that => that.Needs("x", "1.0"))
                 .Package("e", "2.0", that => that.Needs("x", "2.0"))
                 .Package("x", "1.0")
-                .Package("x", "2.0");
+                .Package("x", "2.0")
+                .Package("g", version: null);
 
             var walker = new DependencyWalker(new[] { testProvider });
             walker.Walk("a", new SemanticVersion("1.0"), VersionUtility.ParseFrameworkName("net45"));
@@ -244,7 +245,7 @@ public TestDependencyProvider Package(string name, string version, Action<Entry>
                 Key = new Library
                 {
                     Name = name,
-                    Version = new SemanticVersion(version)
+                    Version = version == null ? null : new SemanticVersion(version)
                 }
             };