Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample on how to deal with computed js files in static web assets #385

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Sample on how to deal with computed js files in static web assets #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b28f16
Deal with computed assets
javiercn Sep 28, 2021
1725929
Merge targets
javiercn Sep 28, 2021
b66126c
Further simplify targets
javiercn Sep 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...spNetCore.Components.CustomElements/Microsoft.AspNetCore.Components.CustomElements.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
<Import Project="js\WebpackBuild.targets" />

<PropertyGroup>
<NpmFolder>js\</NpmFolder>
<NpmCommand>npm run build:$(Configuration)</NpmCommand>
<TargetFramework>net6.0</TargetFramework>
<Nullable>enable</Nullable>
<IsPackable>true</IsPackable>
Expand Down
33 changes: 12 additions & 21 deletions ...CustomElements/src/Microsoft.AspNetCore.Components.CustomElements/js/WebpackBuild.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,38 +1,29 @@
<Project>

<PropertyGroup>
<WebpackOutputFile>wwwroot\BlazorCustomElements.js</WebpackOutputFile>
<DefaultItemExcludes>**\dist\**;**\*.targets;$(DefaultItemExcludes)</DefaultItemExcludes>
</PropertyGroup>

<ItemGroup>
<WebpackBuildInputs Include="$(MSBuildThisFileDirectory)**" Exclude="$(MSBuildThisFileDirectory)node_modules\**" />
<WebpackBuildInputs Include="$(BaseIntermediateOutputPath)webpackconfig.txt" />
<UpToDateCheckInput Include="@(WebpackBuildInputs)" />
<NpmBuildInputs Include="$(NpmFolder)**" Exclude="$(DefaultItemExcludes)" />
</ItemGroup>

<!-- If package-lock.json has changed, perform an NPM install -->
<Target Name="NpmInstall"
Inputs="$(MSBuildThisFileDirectory)package-lock.json"
Outputs="$(BaseIntermediateOutputPath)package-lock.json">
<Target Name="NpmInstall" Inputs="$(NpmFolder)package-lock.json" Outputs="$(NpmFolder)node_modules\.package-lock.json">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to copy package-lock.json to BaseIntermediateOutputPath or similar if we want the incrementalism to work here

<Message Importance="high" Text="Running npm install..." />
<Exec Command="npm install" WorkingDirectory="$(MSBuildThisFileDirectory)" />
<Copy SourceFiles="$(MSBuildThisFileDirectory)package-lock.json"
DestinationFolder="$(BaseIntermediateOutputPath)" />
<Exec Command="npm install" WorkingDirectory="$(NpmFolder)" />
</Target>

<!-- If any source file in this dir or below has changed, perform a Webpack build -->
<Target Name="TrackWebpackBuildConfig">
<WriteLinesToFile File="$(BaseIntermediateOutputPath)webpackconfig.txt" Lines="$(Configuration)" Overwrite="true" WriteOnlyWhenDifferent="true" />
</Target>
<Target Name="NpmRunBuild" DependsOnTargets="NpmInstall" BeforeTargets="AssignTargetPaths" Inputs="@(NpmBuildInputs)" Outputs="$(IntermediateOutputPath)npmbuild.complete.txt">
<Exec Command="$(NpmCommand) -- -o $(IntermediateOutputPath)\npm" WorkingDirectory="$(NpmFolder)" />

<Target Name="WebpackBuild" DependsOnTargets="NpmInstall; TrackWebpackBuildConfig" BeforeTargets="AssignTargetPaths"
Inputs="@(WebpackBuildInputs)"
Outputs="$(WebpackOutputFile)">
<Exec Command="npm run build:$(Configuration)" WorkingDirectory="$(MSBuildThisFileDirectory)" />
<ItemGroup>
<Content Remove="$(WebpackOutputFile)" />
<Content Include="$(WebpackOutputFile)" />
<_NpmOutput Include="$(IntermediateOutputPath)\npm\**"></_NpmOutput>
<Content Include="@(_NpmOutput)" Link="wwwroot\%(_NpmOutput.RecursiveDir)\%(_NpmOutput.FileName)%(_NpmOutput.Extension)" />
<FileWrites Include="$(IntermediateOutputPath)npmbuild.complete.txt" />
</ItemGroup>

<WriteLinesToFile File="$(IntermediateOutputPath)npmbuild.complete.txt" Lines="@(_NpmOutput)" />
</Target>

</Project>