Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rust branch #133

Open
wants to merge 141 commits into
base: main
Choose a base branch
from
Open

Add Rust branch #133

wants to merge 141 commits into from

Conversation

ochibani
Copy link
Contributor

@ochibani ochibani commented Apr 8, 2023

This is a rust code that is still being tested.
The goal is to follow the same approach that the Python code was written in order to have working rust code, and then to improve it.
I think the code can be improved in the future, like using libbtrfsutil, dropping python-anytree, and using the command line less.
The benefit from this is having a single executable binary file that can be easily packaged.

@i2
Copy link
Member

i2 commented Apr 8, 2023

Thanks for the PR. I will do it. In fact, I was about to announce this. Removing anytree and making ash more solid, cross-platform has been high on my priority list for the project.

@i2
Copy link
Member

i2 commented Apr 24, 2023

Good progress!
I'll leave this PR open till it's in good shape and the three mentioned issues are resolved.

@i2
Copy link
Member

i2 commented May 1, 2023

@ochibani There would be some updates in the next few days.
I would say, keep a close eye on the python code changes and reflect them on Rust as they come. Thanks!

Also, I'd recommend joining private #dev channel on Discord. We also have Matrix.

@i2
Copy link
Member

i2 commented May 6, 2023

If you look at the new code submissions recently, you might realize I'm slowly relaxing the strict POSIX requirement and implementing functions etc. pythonically. (again python might not be target language and it's just what's used right now) I highly recommend following the same thing as much as you can so merge could be easy in future. As much as you can avoid shell.

Good work!

@ochibani
Copy link
Contributor Author

ochibani commented May 6, 2023

For now, I am unable to catch up with changes, but don't worry, I will add them to the code.

@ochibani
Copy link
Contributor Author

I'll begin working on the cli, while also investigating and updating the code.

Cargo.toml Outdated
@@ -9,12 +9,13 @@ edition = "2021"
name = "lib"
path = "src/lib.rs"

[features]
[features] #REVIEW
#TODO add import & lock feature
default = ["arch"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is meant for Arch Linux, is there a way to avoid mentioning it here (to make this file more generic)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just default value for compiler. It can be changed from cargo during build time, but I think I may change this.

@ochibani
Copy link
Contributor Author

ochibani commented Feb 6, 2024

I will begin adding auto-completion support for bash, fish, and zsh.

@ochibani
Copy link
Contributor Author

ochibani commented Feb 8, 2024

Add support for apt and dnf should be the last task here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants