Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nimble 12 changed the Expectation API #266

Merged
merged 1 commit into from Apr 23, 2023

Conversation

younata
Copy link
Collaborator

@younata younata commented Apr 14, 2023

No description provided.

@younata younata requested a review from ashfurrow April 23, 2023 18:29
@younata
Copy link
Collaborator Author

younata commented Apr 23, 2023

@ashfurrow can you take a look at this when you get a chance?

CI is failing because of danger - because I'm making this PR from my own fork of Nimble-Snapshots.

Copy link
Owner

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey cool! Thanks for the PR.

CI is actually silently failing on this repo, I need to fix it (#257). Since I don't use the library day-to-day anymore, it's fallen off my radar.

Looks like this PR is compiling with carthage 👍 Let's merge.

@ashfurrow ashfurrow merged commit bc7d2c7 into ashfurrow:master Apr 23, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants