New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Swift Package definition #255
Conversation
Signed-off-by: Diogo Tridapalli <diogot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I don’t use Swift day-to-day anymore so I appreciate this pull request. Swift had never made any syntax it doesn’t want to change later, eh? 😂😭
Don't worry, I use Swift daily but never write package descriptions too, hehe. |
Nah it's probably unrelated – probably a permission thing running from a fork. Merging 👍 |
Oh wait, Danger failed before the tests got ran. Let me run them locally. Danger should be configured to run last to avoid this. |
Okay! So tests are failing, but they're failing on |
Thanks a lot for contributing @diogot! You've been invited to be a collaborator on this repo – no pressure to accept! If you'd like more information on what this means, check out the Moya contributor guidelines and feel free to reach out with any questions. Generated by 🚫 dangerJS |
Hi, sorry for the delay, too many things happening. |
Is this (create a new release) something that I can do? |
Unfortunately, I need to do it because releasing involves both pushing a tag to GitHub and a CocoaPods podspec. I know this is an SPM-only change but I want to keep them in lockstep. I've pushed up this change in version 9.5.1 and the podspec is pushing now. You should be good to go, let me know 👍 Thanks for your patience on this – I've had a death in the family recently and open source hasn't been a priority for me. |
I'm sorry for you loss 😔 Regarding the release everything is working great, and thank you very much for been so helpful! |
The update to Nimble 11 something had broking in the Package configuration, I fixed it and also update to new syntax to avoid deprecation warnings.