Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Swift Package definition #255

Merged
merged 2 commits into from Nov 22, 2022
Merged

Conversation

diogot
Copy link
Collaborator

@diogot diogot commented Nov 20, 2022

The update to Nimble 11 something had broking in the Package configuration, I fixed it and also update to new syntax to avoid deprecation warnings.

Signed-off-by: Diogo Tridapalli <diogot@users.noreply.github.com>
Copy link
Owner

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I don’t use Swift day-to-day anymore so I appreciate this pull request. Swift had never made any syntax it doesn’t want to change later, eh? 😂😭

@diogot
Copy link
Collaborator Author

diogot commented Nov 21, 2022

Don't worry, I use Swift daily but never write package descriptions too, hehe.
Did I messed up something that make Danger fail?

@ashfurrow
Copy link
Owner

Nah it's probably unrelated – probably a permission thing running from a fork. Merging 👍

@ashfurrow
Copy link
Owner

Oh wait, Danger failed before the tests got ran. Let me run them locally. Danger should be configured to run last to avoid this.

@ashfurrow
Copy link
Owner

Okay! So tests are failing, but they're failing on master too 😬😅 I've opened #257 to investigate. In the meantime, I'm going to merge. Let me know if we should release a new version of the library.

@ashfurrow ashfurrow merged commit 162c1e2 into ashfurrow:master Nov 22, 2022
@ashfurrow-peril
Copy link

Thanks a lot for contributing @diogot! You've been invited to be a collaborator on this repo – no pressure to accept! If you'd like more information on what this means, check out the Moya contributor guidelines and feel free to reach out with any questions.

Generated by 🚫 dangerJS

@diogot diogot deleted the fix-swift-package branch November 22, 2022 11:01
@diogot
Copy link
Collaborator Author

diogot commented Nov 29, 2022

Hi, sorry for the delay, too many things happening.
I checked and we need a new release.

@diogot
Copy link
Collaborator Author

diogot commented Nov 29, 2022

Is this (create a new release) something that I can do?

@ashfurrow
Copy link
Owner

Unfortunately, I need to do it because releasing involves both pushing a tag to GitHub and a CocoaPods podspec. I know this is an SPM-only change but I want to keep them in lockstep.

I've pushed up this change in version 9.5.1 and the podspec is pushing now. You should be good to go, let me know 👍 Thanks for your patience on this – I've had a death in the family recently and open source hasn't been a priority for me.

@diogot
Copy link
Collaborator Author

diogot commented Dec 14, 2022

I'm sorry for you loss 😔

Regarding the release everything is working great, and thank you very much for been so helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants