New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block quotes for the semantic HTML 5 Converter #4549
base: feature/html-converter-next
Are you sure you want to change the base?
Block quotes for the semantic HTML 5 Converter #4549
Conversation
…erter. Also add tests based on the asciidoctor manual's examples
I added |
Glad to see this taking shape. The paragraph content needs to be wrapped in a paragraph. We should never end up with text adjacent to a block-oriented element. It's simply too difficult to style it using CSS. For a styled paragraph, it should be implicitly wrapped in |
I've added a condition so that content that does not start with a |
Okay. I've tested this a bit. I can imagine someone might start with a leading |
This is not the correct approach. A converter should never do analysis on the generated HTML itself. The information needed here is already available by consulting the content model of the node. If the content model is simple, there will be no |
…nsead of starts_with(<), add missing test body
This MR adds functionality to convert block-quotes in AsciiDoctor for the semantic-html5 converter/backend. I've added the examples from the asciidoctor manual as tests. The
blockquotes-6
test requires unordered lists, which is blocked by MR #4321.This is an example of the old and new output.
OLD:
NEW:
The use of
<header>
for the title matches my latest [suggestions for admonitions]. The use of<footer>
matches MDNs examples https://developer.mozilla.org/en-US/docs/Web/HTML/Element/blockquote.