resolves #3893 allow footnotes in footnotes #3894
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add 2 tests: basic support of footnotes in footnotes and support for escaped ] * Change InlineFootnoteMacroRx so that it allows recursive footnotes * Move footnote processing code from sub_macros to separate function sub_footnote, call it recursively on matches. It is important not to call sub_macros recursively as this results to multiple expansion of some macros (e.g. URL)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tryed my best at following
CONTRIBUTING.adoc, but I have no experience with Ruby and ascidoctor code.Details:
and support for escaped ]
sub_footnote, call it recursively on matches. It is important not
to call sub_macros recursively as this results to multiple expansion
of some macros (e.g. URL)